[PATCH] D61262: [AArch64] Implement MC support for Scalable Vector Extension 2 (SVE2)

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 30 01:52:19 PDT 2019


SjoerdMeijer added a subscriber: t.p.northover.
SjoerdMeijer added a comment.

Oh, I am definitely not interested in checking encodings. Machines are indeed much better in that.

But glancing over the patches would still be useful I think, i.e. the perhaps non-trivial tablegen parts.  I think the patches that at least need to be split up are the parts that deal with the TargetParser, AsmParser, etc. With SVE, we still had quite some comments, even though they were mostly minor, but still.  But at the moment I can't even look at the code, the patch is too big. And then yes, you can probably start committing all the tablegen discriptions in one go, like you did with SVE.

Perhaps good to get some opinions from @olista01 and @t.p.northover on this too.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61262/new/

https://reviews.llvm.org/D61262





More information about the llvm-commits mailing list