[PATCH] D61267: Update Phabricator.rst

[Don Hinton via Phabricator via llvm-commits]

hintonda added a comment.

I've added a few reviewers more familiar with this documentation.

My main concern is the addition of images.  None of the other documentation has any, and I'm not sure about the policy, so I'll leave that question to others.

However, I have made a couple comments below.



================
Comment at: llvm/docs/Phabricator.rst:71
+and ``Subscribers`` in your commit message. ``arc`` requires one or more
+Reviewers (finding-reviewer-names_) and Subscribers should be the appropriate
+**-commits** list(s) from `listinfo <https://lists.llvm.org/mailman/listinfo>`_.
----------------
I think it would be helpful to include the subscribers info @benhamilton provided.


================
Comment at: llvm/docs/Phabricator.rst:168
 
-* Use ``svn blame`` and the commit log to find names of people who have
+* Use ``git blame`` and the commit log to find names of people who have
   recently modified the same area of code that you are modifying.
----------------
You could also mention `arc cover` here.


================
Comment at: llvm/docs/Phabricator.rst:197
+
+The names for Reviewers and Subscribers is the registered Phabricator name for
+the individual. Type the persons "real name" or a portion of the persons "real name" or
----------------
Cut-n-paste error?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61267/new/

https://reviews.llvm.org/D61267