[PATCH] D59521: [WebAssembly] Define the signature for __stack_chk_fail

[Dan Gohman via Phabricator via llvm-commits]

sunfish marked an inline comment as done.
sunfish added inline comments.


================
Comment at: llvm/trunk/lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.cpp:846
+    errs() << "runtime library name: " << Name << "\n";
+    llvm_unreachable("unexpected runtime library name");
+  }
----------------
sbc100 wrote:
> Wouldn't it be nicer to do something like: `llvm_unreachable("unexpected runtime library name: " + Name);`
It's a little more involved in that because all the types are char* and the argument is char*, but it's doable. Done, in r359509.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59521/new/

https://reviews.llvm.org/D59521