[PATCH] D59521: [WebAssembly] Define the signature for __stack_chk_fail
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 29 15:12:21 PDT 2019
sbc100 added inline comments.
================
Comment at: llvm/trunk/lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.cpp:846
+ errs() << "runtime library name: " << Name << "\n";
+ llvm_unreachable("unexpected runtime library name");
+ }
----------------
Wouldn't it be nicer to do something like: `llvm_unreachable("unexpected runtime library name: " + Name);`
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59521/new/
https://reviews.llvm.org/D59521
More information about the llvm-commits
mailing list