[PATCH] D60977: [llvm-profdata] Add overlap command to compute similarity b/w two profile files

[Rong Xu via Phabricator via llvm-commits]

xur marked 4 inline comments as done.
xur added inline comments.


================
Comment at: llvm/lib/ProfileData/InstrProfWriter.cpp:219
+      Name.find(FuncFilter.NameFilter) != Name.npos)
+    ValueCutoff = 0;
+
----------------
davidxl wrote:
> why resetting it to zero?
setting to zero so that the comparison always true in function InstrProfRecord::overlap() (so that we output function level information).
this way we only need to pass the cutoff value rather the filter object.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60977/new/

https://reviews.llvm.org/D60977