[PATCH] D60977: [llvm-profdata] Add overlap command to compute similarity b/w two profile files

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/lib/ProfileData/InstrProf.cpp:1240
+  if (Mismatch.NumEntries)
+    OS << "  EdgeProfile mismatch: "
+       << format("%.3f%%", Mismatch.CountSum * 100) << "\n";
----------------
"mismatched count  percentage(EdgeProfile): " seems more obvious.


================
Comment at: llvm/lib/ProfileData/InstrProf.cpp:1243
+  if (Unique.NumEntries)
+    OS << "  EdgeProfile only in test_profile: "
+       << format("%.3f%%", Unique.CountSum * 100) << "\n";
----------------
percentage of EdgeProfile only in test_profile:


================
Comment at: llvm/lib/ProfileData/InstrProfWriter.cpp:219
+      Name.find(FuncFilter.NameFilter) != Name.npos)
+    ValueCutoff = 0;
+
----------------
why resetting it to zero?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60977/new/

https://reviews.llvm.org/D60977