[PATCH] D61201: [LLD][ELF] Full support for -n (--nmagic) and -N (--omagic)
Stephen Hines via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 26 10:50:29 PDT 2019
srhines marked an inline comment as done.
srhines added inline comments.
================
Comment at: ELF/Driver.cpp:1118
break;
+ case OPT_omagic:
+ case OPT_nmagic:
----------------
srhines wrote:
> This should probably make use of LLVM_FALLTHROUGH.
Actually ignore me. I for some reason thought that there was something else happening in the first case. -Wimplicit-fallthrough doesn't warn for this case, since it is obvious that you are handling both cases the same way.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61201/new/
https://reviews.llvm.org/D61201
More information about the llvm-commits
mailing list