[PATCH] D61201: [LLD][ELF] Full support for -n (--nmagic) and -N (--omagic)

Fri Apr 26 10:43:05 PDT 2019

srhines added a comment.

I had just a few small suggestions to make things more consistent. Feel free to ignore my fallthrough comment, but I feel like -Wimplicit-fallthrough has been quite valuable in Android.

================
Comment at: ELF/Driver.cpp:1118
       break;
+    case OPT_omagic:
+    case OPT_nmagic:
----------------
This should probably make use of LLVM_FALLTHROUGH.

================
Comment at: ELF/Options.td:255
 def omagic: Flag<["--"], "omagic">, MetaVarName<"<magic>">,
-  HelpText<"Set the text and data sections to be readable and writable">;
+  HelpText<"Set the text and data sections to be readable and writable, do not page align sections and link against static libraries">;

----------------
Instead of "and link" this should be just ", link" based on the existing usage.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61201/new/

https://reviews.llvm.org/D61201