[PATCH] D60854: [DAGLegalize][PowerPC] Add promote legalization of addc/adde and subc/sube

[Zixuan Wu via Phabricator via llvm-commits]

wuzish marked 2 inline comments as done.
wuzish added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:10225
       N0.hasOneUse() && !N0.getNode()->hasAnyUseOfValue(1) &&
-      (!LegalOperations || TLI.isOperationLegal(N0.getOpcode(), VT))) {
+      TLI.isOperationLegal(N0.getOpcode(), VT)) {
     SDLoc SL(N);
----------------
efriedma wrote:
> Like I said before, we don't want to change the behavior of ADDCARRY.  So should be something more like `((!LegalOperations && N0.getOpcode() == ISD::ADDCARRY) || TLI.isOperationLegal(N0.getOpcode(), VT))`
OK, I see.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60854/new/

https://reviews.llvm.org/D60854