[PATCH] D61037: [WebAssembly] Implement ReplaceNodeResults to fix a SIMD crash

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added a comment.

We talked offline and it's maybe better to have a bit more picture on how `ReplaceNodeResults` is working before committing this.



================
Comment at: llvm/test/CodeGen/WebAssembly/simd-illegal-signext.ll:8
+; ReplaceNodeResults to resolve, but the default implementation is to
+; abort.
+
----------------
Nit: Can we make it wrap to 80 cols bit more? It currently looks kinda random


================
Comment at: llvm/test/CodeGen/WebAssembly/simd-illegal-signext.ll:15
+; CHECK-NEXT: i32.store16
+define void @foo() #0 {
+entry:
----------------
Nit: we can remove `#0`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61037/new/

https://reviews.llvm.org/D61037