[PATCH] D60348: [COFF, ARM64] Fix ABI implementation of struct returns

[Mandeep Singh Grang via Phabricator via llvm-commits]

mgrang marked an inline comment as done.
mgrang added inline comments.


================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:3435
+    // present.
+    if (TT.isOSWindows() && i->hasStructRetAttr())
+      return false;
----------------
efriedma wrote:
> Can we restrict this to only arguments with both sret and inreg?
> 
> Maybe leave a FIXME to check whether the callee also has an sret+inreg argument.  That optimization isn't critical, but nice to have at some point.
You cannot have inreg without sret. So I think just checking inreg should be enough. Will change this to check for inreg. Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60348/new/

https://reviews.llvm.org/D60348