[PATCH] D60348: [COFF, ARM64] Fix ABI implementation of struct returns

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 22 15:34:21 PDT 2019


efriedma added inline comments.


================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:3435
+    // present.
+    if (TT.isOSWindows() && i->hasStructRetAttr())
+      return false;
----------------
Can we restrict this to only arguments with both sret and inreg?

Maybe leave a FIXME to check whether the callee also has an sret+inreg argument.  That optimization isn't critical, but nice to have at some point.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60348/new/

https://reviews.llvm.org/D60348





More information about the llvm-commits mailing list