[PATCH] D60462: [TargetLowering][AMDGPU][X86] Improve SimplifyDemandedBits bitcast handling

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 22 06:54:21 PDT 2019


RKSimon marked an inline comment as done.
RKSimon added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUISelLowering.cpp:3170
+            DAG.getNode(ISD::SRL, SL, VT, LHS.getOperand(1), N->getOperand(1)));
+      }
+
----------------
@nhaehnle @arsenm I think this handles the BFE issue - I investigated putting this in DAGCombine but it caused a lot of noise on other targets - some improvements, some regressions.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60462/new/

https://reviews.llvm.org/D60462





More information about the llvm-commits mailing list