[PATCH] D60589: [sanitizer_common] Expose a variadic version of the sanitizer Printf function.
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 19 14:34:00 PDT 2019
eugenis added a comment.
>> IMHO, we could use printf() in gwpasan directly, with a guard against recursive malloc.
>
> I don't think this will work in a signal-safe manner. The only times that GwpAsan calls `printf()` is in the signal handler, and even if we temporarily disable sampled allocations, we still are exercising non-reentrant functions in a signal handler.
Right, I did not think of this.
I don't think stdarg.h is dangerous. You could also move the declaration to a separate header.
@kcc ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60589/new/
https://reviews.llvm.org/D60589
More information about the llvm-commits
mailing list