[PATCH] D60589: [sanitizer_common] Expose a variadic version of the sanitizer Printf function.

[Mitch Phillips via Phabricator via llvm-commits]

hctim added a comment.

In D60589#1463704 <https://reviews.llvm.org/D60589#1463704>, @eugenis wrote:

> Is this meant as a test-only thing?


This is meant to be the default printf() implementation for GwpAsan, for if the allocator doesn't provide us with its own printf().

In D60589#1463704 <https://reviews.llvm.org/D60589#1463704>, @eugenis wrote:

> I don't think we want sanitizer Printf anywhere close to production.


Don't we already do this with HWASan/etc?

In D60589#1463704 <https://reviews.llvm.org/D60589#1463704>, @eugenis wrote:

> IMHO, we could use printf() in gwpasan directly, with a guard against recursive malloc.


I don't think this will work in a signal-safe manner. The only times that GwpAsan calls `printf()` is in the signal handler, and even if we temporarily disable sampled allocations, we still are exercising non-reentrant functions in a signal handler.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60589/new/

https://reviews.llvm.org/D60589