[PATCH] D60642: [dsymutil] Collect parseable Swift interfaces in the .dSYM bundle.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl marked an inline comment as done.
aprantl added inline comments.


================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:2513
+    StringRef InterfaceFile = I.second;
+    SmallString<0> InputPath;
+    if (!Options.PrependPath.empty()) {
----------------
JDevlieghere wrote:
> `SmallString<0>`? Also, how about moving this out of the loop and clearing it?
This variable is only going to be used in the unlikely case of Options.PrependPath being set, which basically only happens in the test suite. What's the benefit of hoisting the declaration out of the loop? Avoiding re-allocating the buffer? I think I can do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60642/new/

https://reviews.llvm.org/D60642