[PATCH] D60642: [dsymutil] Collect parseable Swift interfaces in the .dSYM bundle.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 18 09:50:59 PDT 2019


aprantl marked an inline comment as done.
aprantl added inline comments.


================
Comment at: llvm/tools/dsymutil/DwarfLinker.h:498
 
+  /// .swiftinterface files referenced by the debug info.
+  std::map<std::string, std::string> ParseableSwiftInterfaces;
----------------
JDevlieghere wrote:
> Can you explain what the first and second string is? Can this be a StringMap?
I thought about his, too. This is a map from ModuleName->FilePath (I'll add that to the comment). I need the entries to be uniqued and sorted and there are only few entries expected per compile unit. The iteration order over a StringMap isn't well-defined and the RHS would need to be std::strings anyway, so I thought a std::map fits the bill.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60642/new/

https://reviews.llvm.org/D60642





More information about the llvm-commits mailing list