[PATCH] D60353: ELF: Add basic partition data structures and behaviours.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/InputSection.cpp:1091
   Alignment = std::max(Alignment, Other->Alignment);
+  if (Partition != Other->Partition) {
+    Partition = 1;
----------------
This probably needs a comment.


================
Comment at: lld/ELF/MarkLive.cpp:202
 
-  if (Sec->Live)
+  // Set Sec->Partition to the minimum of Partition and Sec->Partition in the
+  // following lattice: 1 < other < 0. If Sec->Partition doesn't change, we
----------------
minimum -> meet?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60353/new/

https://reviews.llvm.org/D60353