[PATCH] D60353: ELF: Add basic partition data structures and behaviours.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/InputSection.h:78
 
+  unsigned : 2;
+
----------------
`unsigned : 1`;


================
Comment at: lld/ELF/Writer.cpp:763
+  RF_NOT_ALLOC = 1 << 24,
+  RF_PARTITION = 1 << 16, // 8 bits
   RF_NOT_INTERP = 1 << 15,
----------------
The comment `8 bits` may be elaborated a bit.


================
Comment at: lld/test/ELF/partitions.s:4
+// RUN: ld.lld %t.o -o %t --export-dynamic --gc-sections
+// RUN: llvm-readobj -sections -symbols -elf-output-style=GNU %t | FileCheck %s
+
----------------
`-symbols` -> `-dyn-syms`?

e.g. `llvm-readelf -S -dyn-syms %t`


================
Comment at: lld/test/ELF/partitions.s:32
+_start:
+call f3
+
----------------
Indent instructions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60353/new/

https://reviews.llvm.org/D60353