[PATCH] D60502: [llvm-nm] Add --special-syms

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D60502#1471500 <https://reviews.llvm.org/D60502#1471500>, @rupprecht wrote:

> Just to see if I understand the comments so far: `--special-syms` is essentially already the default for `llvm-nm` (i.e. we print special symbols), but not for GNU `nm`. And so even though we print special symbols, a configure script that checks if `$NM --special-syms` is supported will fail when it shouldn't.
>
> If so, then LGTM -- this patch makes things less worse in all regards.


There's a counter-example to this though, which I'm concerned about. If we silently accept --special-syms, with it being the default always, there could be configure scripts that don't specify --special-syms that expect to NOT see those symbols (e.g. they're looking for all "normal" symbols). This in turn could result in a silent breakage.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60502/new/

https://reviews.llvm.org/D60502