[PATCH] D60502: [llvm-nm] Add --special-syms

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 18 04:19:42 PDT 2019


rupprecht added a comment.

Just to see if I understand the comments so far: `--special-syms` is essentially already the default for `llvm-nm` (i.e. we print special symbols), but not for GNU `nm`. And so even though we print special symbols, a configure script that checks if `$NM --special-syms` is supported will fail when it shouldn't.

If so, then LGTM -- this patch makes things less worse in all regards. If it's not the case, e.g. `llvm-nm` doesn't print special symbols but we want `llvm-nm --special-syms` to work in order to trick configure scripts, I think this can lead to confusion -- it is much easier to track down failures if the flag is not at all supported than if it is silently ignored.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60502/new/

https://reviews.llvm.org/D60502





More information about the llvm-commits mailing list