[PATCH] D60858: AMDGPU: Skip debug instructions in assert

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 18 03:35:53 PDT 2019


arsenm added a comment.

In D60858#1471444 <https://reviews.llvm.org/D60858#1471444>, @Orlando wrote:

> Are the function attributes in the test necessary? Watching other reviews leads me to believe these are undesirable. Apart from this it LGTMy untrained eyes (I'm new to reviewing!).


They're part of the intrinsic declarations, so they're really there either way. I usually leave the ones part of the intrinsic definition


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60858/new/

https://reviews.llvm.org/D60858





More information about the llvm-commits mailing list