[PATCH] D60858: AMDGPU: Skip debug instructions in assert

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 18 03:14:47 PDT 2019

Previous message: [PATCH] D60858: AMDGPU: Skip debug instructions in assert
Next message: [PATCH] D60858: AMDGPU: Skip debug instructions in assert
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Orlando added a comment.

Are the function attributes in the test necessary? Watching other reviews leads me to believe these are undesirable. Apart from this it LGTMy untrained eyes (I'm new to reviewing!).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60858/new/

https://reviews.llvm.org/D60858

Previous message: [PATCH] D60858: AMDGPU: Skip debug instructions in assert
Next message: [PATCH] D60858: AMDGPU: Skip debug instructions in assert
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list