[PATCH] D60676: [NewPM] Add Option handling for SimpleLoopUnswitch

[Serguei Katkov via Phabricator via llvm-commits]

skatkov marked 2 inline comments as done.
skatkov added inline comments.


================
Comment at: lib/Passes/PassBuilder.cpp:1432
+    bool Enable = !ParamName.consume_front("no-");
+    if (ParamName == "non-trivial") {
+      Result = Enable;
----------------
fedor.sergeev wrote:
> can we make it "nontrivial" without a dash?
> Otherwise no-non-trivial looks too weird...
ok.


================
Comment at: lib/Passes/PassBuilder.cpp:1441
+  }
+  return Result;
+}
----------------
fedor.sergeev wrote:
> What happens if params are empty?
> There should be some default initialization.
SimpleLoopUnswitchPass has a default value 
NonTrivial = false


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60676/new/

https://reviews.llvm.org/D60676