[PATCH] D60676: [NewPM] Add Option handling for SimpleLoopUnswitch

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev requested changes to this revision.
fedor.sergeev added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/Passes/PassBuilder.cpp:1432
+    bool Enable = !ParamName.consume_front("no-");
+    if (ParamName == "non-trivial") {
+      Result = Enable;
----------------
can we make it "nontrivial" without a dash?
Otherwise no-non-trivial looks too weird...


================
Comment at: lib/Passes/PassBuilder.cpp:1441
+  }
+  return Result;
+}
----------------
What happens if params are empty?
There should be some default initialization.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60676/new/

https://reviews.llvm.org/D60676