[PATCH] D60602: [InferAddressSpaces] Add AS parameter to the pass factory
Kévin Petit via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 17 06:20:36 PDT 2019
kpet added inline comments.
================
Comment at: include/llvm/Transforms/Scalar.h:383
// on the target.
//
+FunctionPass *createInferAddressSpacesPass(unsigned AS = ~0u);
----------------
arsenm wrote:
> Parameter name should be more descriptive. The comment also needs to be updated
Will do. I assumed that given that `AddressSpace` is shortened to `AS` in a lot of place, I could do it here as well.
================
Comment at: lib/Transforms/Scalar/InferAddressSpaces.cpp:631
+ if (FlatAddrSpace == UninitializedAddressSpace) {
+
+ FlatAddrSpace = TTI.getFlatAddressSpace();
----------------
arsenm wrote:
> Extra blank line here. Also should sink the getAnalysis into here
Will remove the line. Not sure moving `getAnalysis` into this block helps. It is still required as you pointed out.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60602/new/
https://reviews.llvm.org/D60602
More information about the llvm-commits
mailing list