[PATCH] D60602: [InferAddressSpaces] Add AS parameter to the pass factory

Kévin Petit via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 17 06:13:26 PDT 2019


kpet added a comment.

@arsenm Thanks for the review.

> This is still requiring the TTI as a dependency, so I don't understand what this solves?

The TTI is currently used for two things:

- `getFlatAddressSpace` which is absolutely required to return a non-default value for the pass to be able to function
- `hasVolatileVariant` which enables the pass to handle additional cases. The default TTI implementation will return `false` which is good enough for many uses.

This change enables >95% of the functionality of this pass to be used with the default TTI.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60602/new/

https://reviews.llvm.org/D60602





More information about the llvm-commits mailing list