[PATCH] D60324: [llvm-objcopy] Add switch to allow removing referenced sections

[James Henderson via Phabricator via llvm-commits]

jhenderson marked an inline comment as done.
jhenderson added inline comments.


================
Comment at: tools/llvm-objcopy/ELF/Object.cpp:440
+          "referenced by the symbol table %s",
+          SymbolNames->Name.data(), this->Name.data());
   return removeSymbols(
----------------
grimar wrote:
> jhenderson wrote:
> > grimar wrote:
> > > Perhaps also be consistent here?
> > > 
> > > 
> > > ```
> > > if (ToRemove(SymbolNames)) {
> > >     if (!AllowBrokenDependencies)
> > >       return createStringError(
> > >           llvm::errc::invalid_argument,
> > >           "String table %s cannot be removed because it is "
> > >           "referenced by the symbol table %s",
> > >           SymbolNames->Name.data(), this->Name.data());
> > > 
> > >     SymbolNames = nullptr;
> > > }
> > > ```
> > Thanks, I missed this one.
> nit: still not updated :)
I know, I haven't updated the diff yet ;)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60324/new/

https://reviews.llvm.org/D60324