[PATCH] D60324: [llvm-objcopy] Add switch to allow removing referenced sections

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

Ok, this looks fine I think. Maybe worth to hold this for a while time to check that there
are no objections about the new option name/description (or anything else).



================
Comment at: tools/llvm-objcopy/ELF/Object.cpp:440
+          "referenced by the symbol table %s",
+          SymbolNames->Name.data(), this->Name.data());
   return removeSymbols(
----------------
jhenderson wrote:
> grimar wrote:
> > Perhaps also be consistent here?
> > 
> > 
> > ```
> > if (ToRemove(SymbolNames)) {
> >     if (!AllowBrokenDependencies)
> >       return createStringError(
> >           llvm::errc::invalid_argument,
> >           "String table %s cannot be removed because it is "
> >           "referenced by the symbol table %s",
> >           SymbolNames->Name.data(), this->Name.data());
> > 
> >     SymbolNames = nullptr;
> > }
> > ```
> Thanks, I missed this one.
nit: still not updated :)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60324/new/

https://reviews.llvm.org/D60324