[PATCH] D60765: [ELF] Place SectionPiece::{Live,Hash} bit fields together

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 16 21:32:58 PDT 2019


MaskRay added a comment.

  uint32_t Hash;
  uint8_t Live : 1;
  uint8_t TailShardId : 5;
  uint8_t OutputOffHi;
  uint32_t OutputOffLo;

Do you mean

  // 16 bytes -> 12 bytes
  uint32_t InputOff;
  
  uint32_t Live : 1
  uint32_t Hash : 18;
  uint32_t TailShardId : 5;
  uint32_t OutputOffHi : 8;
  
  uint32_t OutputOffLo;

Looks fine.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60765/new/

https://reviews.llvm.org/D60765





More information about the llvm-commits mailing list