[PATCH] D60765: [ELF] Place SectionPiece::{Live,Hash} bit fields together
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 16 07:28:13 PDT 2019
MaskRay added a comment.
> Did you run lld with this change to see if the increase of hash collision doesn't have a negative impact?
This patch has improvement, likely due to 2938: `if (!Sec->Pieces[I].Live) return;`
Before: 19.871 +- 0.149 seconds time elapsed ( +- 0.75% )
After: 19.207 +- 0.118 seconds time elapsed ( +- 0.61% )
> I'm trying to add another field to the struct which is likely to conflict with this change.
Do you mean D38528 <https://reviews.llvm.org/D38528>? I haven't read that. I'll check that and think about your comments carefully tomorrow.
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60765/new/
https://reviews.llvm.org/D60765
More information about the llvm-commits
mailing list