[PATCH] D60747: Remove EnableEarlyCSEMemSSA option
Eric Christopher via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 16 17:07:10 PDT 2019
echristo updated this revision to Diff 195490.
echristo added a comment.
Update for the new pass manager as well. :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60747/new/
https://reviews.llvm.org/D60747
Files:
llvm/lib/Passes/PassBuilder.cpp
llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
Index: llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
===================================================================
--- llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
+++ llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
@@ -123,10 +123,6 @@
cl::desc("Control the amount of inlining in pre-instrumentation inliner "
"(default = 75)"));
-static cl::opt<bool> EnableEarlyCSEMemSSA(
- "enable-earlycse-memssa", cl::init(true), cl::Hidden,
- cl::desc("Enable the EarlyCSE w/ MemorySSA pass (default = on)"));
-
static cl::opt<bool> EnableGVNHoist(
"enable-gvn-hoist", cl::init(false), cl::Hidden,
cl::desc("Enable the GVN hoisting pass (default = off)"));
@@ -335,7 +331,7 @@
// Start of function pass.
// Break up aggregate allocas, using SSAUpdater.
MPM.add(createSROAPass());
- MPM.add(createEarlyCSEPass(EnableEarlyCSEMemSSA)); // Catch trivial redundancies
+ MPM.add(createEarlyCSEPass(true /* Enable mem-ssa. */)); // Catch trivial redundancies
if (EnableGVNHoist)
MPM.add(createGVNHoistPass());
if (EnableGVNSink) {
Index: llvm/lib/Passes/PassBuilder.cpp
===================================================================
--- llvm/lib/Passes/PassBuilder.cpp
+++ llvm/lib/Passes/PassBuilder.cpp
@@ -184,10 +184,6 @@
cl::Hidden, cl::ZeroOrMore,
cl::desc("Run NewGVN instead of GVN"));
-static cl::opt<bool> EnableEarlyCSEMemSSA(
- "enable-npm-earlycse-memssa", cl::init(true), cl::Hidden,
- cl::desc("Enable the EarlyCSE w/ MemorySSA pass for the new PM (default = on)"));
-
static cl::opt<bool> EnableGVNHoist(
"enable-npm-gvn-hoist", cl::init(false), cl::Hidden,
cl::desc("Enable the GVN hoisting pass for the new PM (default = off)"));
@@ -377,7 +373,7 @@
FPM.addPass(SROA());
// Catch trivial redundancies
- FPM.addPass(EarlyCSEPass(EnableEarlyCSEMemSSA));
+ FPM.addPass(EarlyCSEPass(true /* Enable mem-ssa. */));
// Hoisting of scalars and load expressions.
if (EnableGVNHoist)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60747.195490.patch
Type: text/x-patch
Size: 2015 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190417/24882662/attachment.bin>
More information about the llvm-commits
mailing list