[PATCH] D60747: Remove EnableEarlyCSEMemSSA option

Tue Apr 16 16:43:27 PDT 2019

echristo added a comment.

In D60747#1469518 <https://reviews.llvm.org/D60747#1469518>, @echristo wrote:

> In D60747#1469517 <https://reviews.llvm.org/D60747#1469517>, @george.burgess.iv wrote:
>
> > I can't find any users of this flag, so I'm in favor of s/EnableEarlyCSEMemSSA/true/ if that simplifies things.
> >
> > > Is this still useful for debugging problems with MemSSA and GVNHoist?
> >
> > If we just have to tweak this one place, IMO it's sufficiently straightforward to just manually flip between true/false in code. I've personally never used it to debug anything, though I can only speak for myself.
>
>
> That was pretty much my thought. As far as the new pass manager - the flag isn't being used anywhere else other than this location :)

Except there's a subtly different one there. I'll also remove that.

-eric

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60747/new/

https://reviews.llvm.org/D60747