[PATCH] D60787: [scudo][standalone] Introduce the Secondary allocator

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad added inline comments.


================
Comment at: lib/scudo/standalone/secondary.h:165
+    const uptr Size = H->MapSize;
+    OpaquePlatformData PlatformData;
+    memcpy(&PlatformData, &H->PlatformData, sizeof(PlatformData));
----------------
vitalybuka wrote:
> Why not to typedef OpaquePlatformData to something meaningful on each platform?
> template is also fine, but I don't expect you will need multiple instantiations of MapAllocator
> So maybe just define PlatformData on each platform?
This is a valid point.
Initially I didn't want the secondary to depend on platform specific structures, but I can look into it.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60787/new/

https://reviews.llvm.org/D60787