[PATCH] D60787: [scudo][standalone] Introduce the Secondary allocator
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 16 13:52:09 PDT 2019
vitalybuka added inline comments.
================
Comment at: lib/scudo/standalone/secondary.h:165
+ const uptr Size = H->MapSize;
+ OpaquePlatformData PlatformData;
+ memcpy(&PlatformData, &H->PlatformData, sizeof(PlatformData));
----------------
Why not to typedef OpaquePlatformData to something meaningful on each platform?
template is also fine, but I don't expect you will need multiple instantiations of MapAllocator
So maybe just define PlatformData on each platform?
Repository:
rCRT Compiler Runtime
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60787/new/
https://reviews.llvm.org/D60787
More information about the llvm-commits
mailing list