[PATCH] D60583: [AArch64] Implement Vector Funtion ABI name mangling.

Francesco Petrogalli via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 11:51:43 PDT 2019


fpetrogalli marked 6 inline comments as done.
fpetrogalli added inline comments.


================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:9686
+
+  if (QT->isFloatingType())
+    return true;
----------------
ABataev wrote:
> fpetrogalli wrote:
> > ABataev wrote:
> > > I would suggest to checks the size of the type according to the AAVFABI and limit it with the values 1,2,4 and 8 explicitly (just in case, to handle future types)
> > Just for FP types? Or also for integer types?
> This req is applied to all the types, I think
I have added also the 16 bytes check for the complex types, and related TODO.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60583/new/

https://reviews.llvm.org/D60583





More information about the llvm-commits mailing list