[PATCH] D60583: [AArch64] Implement Vector Funtion ABI name mangling.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:9686
+
+  if (QT->isFloatingType())
+    return true;
----------------
fpetrogalli wrote:
> ABataev wrote:
> > I would suggest to checks the size of the type according to the AAVFABI and limit it with the values 1,2,4 and 8 explicitly (just in case, to handle future types)
> Just for FP types? Or also for integer types?
This req is applied to all the types, I think


================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:9701
+static unsigned getAArch64LS(QualType QT, ParamKindTy Kind, ASTContext &C) {
+  if (getAArch64MTV(QT, Kind) && QT.getCanonicalType()->isPointerType()) {
+    QualType PTy = QT->getPointeeType().getCanonicalType();
----------------
fpetrogalli wrote:
> ABataev wrote:
> > There is a second part of the requirement `reference to some type T for which PBV(T) is true,`
> ParamKindTy doesn't support ref modifiers. Shall I add a note as a comment?
YOu can still ad a checks for ref types for future fixes and add a TODO/FIXME note


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60583/new/

https://reviews.llvm.org/D60583