[llvm] r358348 - [ConstantRange] Fix unittest after rL358347

[Roman Lebedev via llvm-commits]

The commit message was
> The last use of this helper method was removed by rL302385.
Which is clearly not true, as this commit removed more uses of that method,
that weren't testing the method itself, but using it.
Therefore i'm questioning the whole removal.
Moving it into a static function in tests is another, unrelated matter.

Roman.

On Sun, Apr 14, 2019 at 10:57 AM Fāng-ruì Sòng <maskray at google.com> wrote:
>
> On Sun, Apr 14, 2019 at 2:14 PM Roman Lebedev <lebedev.ri at gmail.com> wrote:
>>
>> Hello.
>>
>> The function was clearly used in unit test, and the way
>> the test was rewritten to avoid it looks more complicated
>> than it was with the function, at least to me..
>>
>> Was there any particular reason it was removed?
>> If not, could you please remove last two commits?
>>
>> Roman.
>
>
> If the helper method simplifies the unittest, shall we define a static function in the unittest? It is not used (useful) in library code as isSizeStrictlySmallerThan/isSizeLargerThan are better.