[llvm] r358348 - [ConstantRange] Fix unittest after rL358347

Fāng-ruì Sòng via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 14 00:57:30 PDT 2019


On Sun, Apr 14, 2019 at 2:14 PM Roman Lebedev <lebedev.ri at gmail.com> wrote:

> Hello.
>
> The function was clearly used in unit test, and the way
> the test was rewritten to avoid it looks more complicated
> than it was with the function, at least to me..
>
> Was there any particular reason it was removed?
> If not, could you please remove last two commits?
>
> Roman.
>

If the helper method simplifies the unittest, shall we define a static
function in the unittest? It is not used (useful) in library code as
isSizeStrictlySmallerThan/isSizeLargerThan are better.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190414/e9f21ee3/attachment.html>


More information about the llvm-commits mailing list