[PATCH] D60616: Make parseBitcodeFile use a named StructType, if it exists and matches.

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

(not all inline remarks were addressed)



================
Comment at: llvm/include/llvm/IR/DerivedTypes.h:271-272
   }
 
+  static StructType *getIfExists(LLVMContext &Context, StringRef Name);
+
----------------
This probably deserves a `///` doxygen comment


================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:1549-1550
+                                           ArrayRef<Type *> EltTys) {
+  StructType * Candidate = StructType::getIfExists(Context, Name);
+  if (Candidate  && EltTys.equals(Candidate->elements()))
+    return Candidate;
----------------
here and elsewhere - not from clang-format
(you can just setup a git pre-commit hook so all your commits will have correct formatting)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60616/new/

https://reviews.llvm.org/D60616