[PATCH] D60616: Make parseBitcodeFile use a named StructType, if it exists and matches.

Arnt Gulbrandsen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 12 09:43:06 PDT 2019


arnt marked an inline comment as done and an inline comment as not done.
arnt added a subscriber: dnsampaio.
arnt added a comment.

@dnsampaio Sorry about that. I looked at my shell history now, and I think I added you because I got a wildcard wrong and picked the most recent two committers for the wrong set of files.



================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:1555-1558
+  int i = EltTys.size();
+  while (i-- > 0)
+    if (Candidate->getElementType(i) != EltTys[i])
+      return nullptr;
----------------
lebedev.ri wrote:
> ```
> if(!EltTys.equals(Candidate->elements()))
>   return nullptr;
> ```
Oh, that's neat. I hadn't noticed that being done elsewhere, but I like it better. I'll push as soon as the unit tests have run.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60616/new/

https://reviews.llvm.org/D60616





More information about the llvm-commits mailing list