[PATCH] D59973: [SLP] Refactoring of the operand reordering code.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:962
+        else
+          llvm_unreachable("Bad Operand");
+      }
----------------
Maybe set to `Failed` here just in case, to prevent possible compiler crash?


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:991
+              // 'Failed'.
+              ReorderingModes[OpIdx] = ReorderingMode::Failed;
+          }
----------------
Shall we undo previously performed swaps in this case, if we could do some reordering earlier?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59973/new/

https://reviews.llvm.org/D59973