[PATCH] D59973: [SLP] Refactoring of the operand reordering code.

[Vasileios Porpodas via Phabricator via llvm-commits]

vporpo added inline comments.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:3222
+// Perform operand reordering on the instructions in VL.
+void BoUpSLP::reorderInputsAccordingToOpcode(ArrayRef<Value *> VL,
+                                             SmallVectorImpl<Value *> &Left,
----------------
ABataev wrote:
> Could you make it static? It is strange to see const `reorder...` function.
Well, it is a member function in order to avoid passing DL and SE as arguments on every call site. Anyway, either is fine with me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59973/new/

https://reviews.llvm.org/D59973