[PATCH] D60577: [X86AsmPrinter] refactor static functions into private methods. NFC
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 11 14:36:25 PDT 2019
smeenai added a comment.
I have zero context on this change specifically, but "we should prefer functions in a private namespace" seems to be the exact opposite of the advice in https://llvm.org/docs/CodingStandards.html#static
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60577/new/
https://reviews.llvm.org/D60577
More information about the llvm-commits
mailing list