[PATCH] D60577: [X86AsmPrinter] refactor static functions into private methods. NFC

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 11 13:42:04 PDT 2019


nickdesaulniers added a comment.

A lot of the other derived AsmPrinters seem to use lowerCamelCase for private methods not used from the base class, rather than UpperCamelCase.  Is that a thing?
https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly
does not clarify.

ie. should I not be UpperCamelCasing these functions until I use them from the base class?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60577/new/

https://reviews.llvm.org/D60577





More information about the llvm-commits mailing list