[PATCH] D60437: Add MM register mapping from CodeView to MC register id

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

In D60437#1462279 <https://reviews.llvm.org/D60437#1462279>, @LuoYuanke wrote:

> In D60437#1461210 <https://reviews.llvm.org/D60437#1461210>, @hans wrote:
>
> > I'm not familiar with the CodeView stuff, rnk is the better person for that, but would it be possible to add a test that exercises this mapping? Or to put it another way, what does this fix that's currently broken, and is it possible to add a test for it?
>
>
> I try to add such test case, but I don't find any existing test case for mapping codeveiw register to MC register.
>  @rnk
>  Do you know if there is any reference test case in llvm/test code?


You can try removing a bunch of the entries in RegMap and see which tests fail. They're all in llvm/tests/DebugInfo/COFF/
I don't think there's any test for the mapping itself, but the tests rely on it to work.

That's what my second question was about: what is currently not working that your patch is fixing, and can that be used to write a test?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60437/new/

https://reviews.llvm.org/D60437