[PATCH] D60042: [llvm-objcopy] Add --prefix-alloc-sections

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Having looked at this a bit more, I wonder if this should be part of the existing SectionsToRename loop. After all, there isn't much difference between the two behaviours, apart from the fact that this new switch doesn't change the flags. Would you mind folding the two loops together? As a side effect of this, I expect you might want to rename relocation sections when --rename-section alone is used, which I don't think is currently happening.

Also @jakehehrlich explicitly requested changes, I'd like him to give a thumbs up before I commit this. Thanks for the work @seiya!



================
Comment at: llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp:583-584
 
   if (!Config.SectionsToRename.empty()) {
     for (auto &Sec : Obj.sections()) {
       const auto Iter = Config.SectionsToRename.find(Sec.Name);
----------------
This is the loop I'm talking about in the out-of-line comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60042/new/

https://reviews.llvm.org/D60042