[PATCH] D60042: [llvm-objcopy] Add --prefix-alloc-sections

[Seiya Nuta via Phabricator via llvm-commits]

seiya marked 4 inline comments as done.
seiya added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/prefix-alloc-sections.test:3
+# RUN: llvm-objcopy --prefix-alloc-sections=.alloc_prefix %t %t2
+# RUN: llvm-readobj --sections %t2 | FileCheck %s
+
----------------
rupprecht wrote:
> seiya wrote:
> > jhenderson wrote:
> > > jhenderson wrote:
> > > > rupprecht wrote:
> > > > > It'd be good to check --relocs as well
> > > > Dumb question maybe, but what does this give us?
> > > I'm still not sure what extra coverage --relocs gives us. Could somebody explain, please?
> > I think it would be good to make sure that this feature (--prefix-alloc-sections) does not destroy the contents of relocation sections other than their names. I should add a comment here.
> > 
> > How do you think @rupprecht ?
> After talking to James offline, the --relocs effectively isn't testing anything in addition to what's already covered, so it should be fine to remove. Sorry for suggesting that.
No problem! I've updated the diff.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60042/new/

https://reviews.llvm.org/D60042