[PATCH] D60154: [PGO] Better handling of profile hash mismatch

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1155
+        dbgs() << "Inconsistent number of counts in, skipping this function");
+    Ctx.diagnose(DiagnosticInfoPGOProfile(
+        M->getName().data(),
----------------
xur wrote:
> davidxl wrote:
> > What is the possible cause of it? It is better emit the information so that users can take some actions -- otherwise the message is not useful.
> this is profile mismatch, usually from stale profile (source change), or using the profile generated from other binaries. Is this the standard message for mismatch? We have the check here for the cases that escapes funchash conflict detection. 
When there is a hash conflict, it means the function name is also the same.   Perhaps add more information: " the profile may be stale or there is a function name collision".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60154/new/

https://reviews.llvm.org/D60154