[PATCH] D60154: [PGO] Better handling of profile hash mismatch

Wed Apr 10 10:25:02 PDT 2019

xur marked 3 inline comments as done.
xur added inline comments.

================
Comment at: lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1155
+        dbgs() << "Inconsistent number of counts in, skipping this function");
+    Ctx.diagnose(DiagnosticInfoPGOProfile(
+        M->getName().data(),
----------------
davidxl wrote:
> What is the possible cause of it? It is better emit the information so that users can take some actions -- otherwise the message is not useful.
this is profile mismatch, usually from stale profile (source change), or using the profile generated from other binaries. Is this the standard message for mismatch? We have the check here for the cases that escapes funchash conflict detection. 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60154/new/

https://reviews.llvm.org/D60154